Question Event Based Regeneration

Not sure this is to blame, but ATBMUD has been crashing a lot recently-ish and I know this was added there.

I am adding this to JediMUD and it is going to get put through a ton of testing this weekend. I plan to try and integrate into mud_events and dg_events and i will deep dive the free issue Whiskytest mentioned.

I had to stop, i had to many crashes using it. I had it almost all the way patched using the LISTS, but after reading several of Thomas's responses i gave up that path and tried just patching as is. That crashed way to much, and it has to do with how I have my current regen system in. I may give it another shot but i am late with another release.

Take two (or ten..) is attached.
Tested on the latest tbaMUD 2018.1, no crashes so far.

It integrates with the existing mud_event system as originally intended.

Just make sure wherever points are changed you don't touch them directly, but use alter_hit(), alter_mana() etc.

Keeping in mind that I've got your first stab at this running in my game, is there meant to be an update to regen.c?

regen.o: In function `alter_mana':
/home/atbmud/atbmud2018/src/regen.c:165: multiple definition of `alter_mana'
limits.o:/home/atbmud/atbmud2018/src/limits.c:549: first defined here
regen.o: In function `alter_move':
/home/atbmud/atbmud2018/src/regen.c:198: multiple definition of `alter_move'
limits.o:/home/atbmud/atbmud2018/src/limits.c:567: first defined here
regen.o: In function `alter_hit':
/home/atbmud/atbmud2018/src/regen.c:107: multiple definition of `alter_hit'
limits.o:/home/atbmud/atbmud2018/src/limits.c:532: first defined here
regen.o: In function `check_regen_rates':
/home/atbmud/atbmud2018/src/regen.c:229: multiple definition of `check_regen_rates'
limits.o:/home/atbmud/atbmud2018/src/limits.c:585: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [../bin/circle] Error 1
make[1]: Leaving directory `/home/atbmud/atbmud2018/src'
make: *** [all] Error 2

Yep regen.c can be deleted completely as all those functions were moved to limits.c.

Actually I wouldn't advise putting this in to a live MUD just yet; further testing today has revealed that when a character quits the game, two warnings appear:

:: WARNING: Attempting to get content from iterator with NULL list.
:: WARNING: Attempting to remove iterator from NULL list.

The MUD doesn't crash - but there is something screwy with the event_cancel part of players leaving the game.
Will keep plodding away at this haha

Edit: these warnings only appear when more than one event is still queued on the player. A single event cancels fine without the warnings.