Correction the code is:
Code:
CREATE(new_descr, struct extra_descr_data, 1);
new_descr->keyword = fread_string(fl, buf2);
new_descr->description = fread_string(fl, buf2);
well, the function fread_string(fl, buf2) return an allocated memory using strdup.
fread_string end with this line.
Code:
return (strlen(buf) ? strdup(buf) : NULL);
So, since he want to create a bigger string. He needs to free new_descr->description,
and create a new one.
He want to create a new one bigger by 3 chars, to hold \r\n\x0
This is a bug fix, if you read the comments. He want to make sure new_descr->description end with "\r\n"
Amazingly, fread_string seems to do that, but not in some case... which, seems to be a design problem.
Code:
/* If there is a '~', end the string; else put an "\r\n" over the '\n'. */
/* now only removes trailing ~'s -- Welcor */
point = strchr(tmp, '\0');
for (point-- ; (*point=='\r' || *point=='\n'); point--);
if (*point=='~') {
*point='\0';
done = 1;
} else {
*(++point) = '\r';
*(++point) = '\n';
*(++point) = '\0';
}
Note: it seems that fread_string could return NULL, so therorically
char *end = strchr(new_descr->description, '\0');
could crash.
Bob
)
