Question New age code, pls read and comment and help fix it

// TBAMUD STOCK AGE:

struct time_info_data *age(struct char_data *ch)
{
static struct time_info_data player_age;

player_age = *mud_time_passed(time(0), ch->player.time.birth);

player_age.year += 17; /* All players start at 17 */

return (&player_age);
}



// MY AGE CODE: .

Firstly with the thamud code setting people ages works fine they start as age 17 and if i with set changed to 25 it will be 25.


As you can see in my code i only added cases for each race like:
case RACE_DWARF:
player_age.year += 58; // this line is like the one in TBAMUD code just 58 instead of 17.
break; // break and on to next case


With my code people start with the age i specified BUT THEN if i with set change from dwarfs start age 58 to lets say 65 it will be set to 66.

BIG question is why ?

Should i remove:
default:
in case RACE_HUMAN ?

I see no reason it'd be adding 1 to the number you specify, the cause is likely in the set code, and not in that section, though that last bit is rather messy, but shouldn't be related.

Default cases aren't always necessary, they're typically considered good coding practice though, but when used they shouldn't be used like that, either of the following would be better:

Now i tryed this:

struct time_info_data *age(struct char_data *ch)
{
static struct time_info_data player_age;

player_age = *mud_time_passed(time(0), ch->player.time.birth);
switch (GET_RACE(ch))
{
case RACE_HUMAN:
player_age.year += 18;
break;

case RACE_ELF:
player_age.year += 118;
break;

case RACE_GNOME:
player_age.year += 80;
break;

case RACE_DWARF:
player_age.year += 58;
break;

default:
player_age.year += 17;
break;
}

return (&player_age);
}

Now i tried the code like this:
I made a gnome with age 80 so far so good, then i set age in game to 100 BUT now the player got to be 163 ???????????????? wtf

do_set: your age:

(100-17)+80 = 163...

After trying above age code i went back to stock age code, but now suddently people dont seem to age, they stay at 17

Whats up with that ?

I'm going to assume you have a some kind of source code versioning system in place. Have you tried diff'ing the code versions?