Question Need help with a race issue - Still need help on this subject.

Hey

Im trying to make races do more with this, does it look ok ?
first part down to else { is males heights, after else { is females:

void set_height_by_race(struct char_data *ch)
{
if (GET_SEX(ch) == SEX_MALE)
{
if (IS_HALF_GIANT(ch))
GET_HEIGHT(ch) = 180 + dice(1, 10);
else if (IS_DWARF(ch))
GET_HEIGHT(ch) = 43 + dice(1, 10);
else if (IS_GNOME(ch))
GET_HEIGHT(ch) = 38 + dice(1, 6);
else if (IS_ELF(ch))
GET_HEIGHT(ch) = 55 + dice(1, 10);
else /* if (IS_HUMAN(ch)) */
GET_HEIGHT(ch) = 60 + dice(2, 10);
}
else { /* if (IS_FEMALE(ch)) */
if (IS_HALF_GIANT(ch))
GET_HEIGHT(ch) = 170 + dice(1, 10);
else if (IS_DWARF(ch))
GET_HEIGHT(ch) = 41 + dice(1, 10);
else if (IS_GNOME(ch))
GET_HEIGHT(ch) = 36 + dice(1, 6);
else if (IS_ELF(ch))
GET_HEIGHT(ch) = 50 + dice(1, 10);
else /* if (IS_HUMAN(ch)) */
GET_HEIGHT(ch) = 59 + dice(2, 10);
}

return;
}


The half giant part should make them taller then 180 centimeters, but i made a test char that turned out to be only 96 centimeters.

Anyone who can help me get this to work, pls ?
Like is there something missing in the height code ?

Character height is a ubyte:
unsigned bytes have values in the range 0-255, and it should work for you. However, it may be wrong where you print it out; please check that function.

I just found this in DB.C:
/* Bias the height and weight of the character depending on what gender
* they have chosen. While it is possible to have a tall, heavy female it's
* not as likely as a male. Height is in centimeters. Weight is in pounds.
* The only place they're ever printed (in stock code) is SPELL_IDENTIFY. */
if (GET_SEX(ch) == SEX_MALE) {
GET_WEIGHT(ch) = rand_number(120, 180);
GET_HEIGHT(ch) = rand_number(160, 200); /* 5'4" - 6'8" */
} else {
GET_WEIGHT(ch) = rand_number(100, 160);
GET_HEIGHT(ch) = rand_number(150, 180); /* 5'0" - 6'0" */
}

1: Could that have affected my race height code ?
2: Could this code above be changed instead into something simuler to my code ?

Maybe just put my code in there instead:
if (GET_SEX(ch) == SEX_MALE) {
if (IS_HALF_GIANT(ch))
GET_WEIGHT(ch) = 180 + dice(1, 10);
GET_HEIGHT(ch) = 180 + dice(1, 10);
else if (IS_DWARF(ch))
GET_WEIGHT(ch) = 43 + dice(1, 10);
GET_HEIGHT(ch) = 43 + dice(1, 10);
else if (IS_GNOME(ch))
GET_WEIGHT(ch) = 43 + dice(1, 10);
GET_HEIGHT(ch) = 43 + dice(1, 10);
else if (IS_ELF(ch))
GET_WEIGHT(ch) = 55 + dice(1, 10);
GET_HEIGHT(ch) = 55 + dice(1, 10);
else /* if (IS_HUMAN(ch)) */
GET_WEIGHT(ch) = 60 + dice(2, 10);
GET_HEIGHT(ch) = 60 + dice(2, 10);
} else { /* if (IS_FEMALE(ch)) */
if (IS_HALF_GIANT(ch))
GET_WEIGHT(ch) = 170 + dice(1, 10);
GET_HEIGHT(ch) = 170 + dice(1, 10);
else if (IS_DWARF(ch))
GET_WEIGHT(ch) = 41 + dice(1, 10);
GET_HEIGHT(ch) = 41 + dice(1, 10);
else if (IS_GNOME(ch))
GET_WEIGHT(ch) = 36 + dice(1, 6);
GET_HEIGHT(ch) = 36 + dice(1, 6);
else if (IS_ELF(ch))
GET_WEIGHT(ch) = 50 + dice(1, 10);
GET_HEIGHT(ch) = 50 + dice(1, 10);
else /* if (IS_HUMAN(ch)) */
GET_WEIGHT(ch) = 59 + dice(2, 10);
GET_HEIGHT(ch) = 59 + dice(2, 10);
}

Something I have always done when coding and think another piece of code is affecting another is to comment out the code and test.
From what you have posted it does look like that other code is affecting yours. Probably no reason why you could not replace that piece of code with yours.

Just add the code test and see what happens.

I really need to get back up to speed with this codebase. Last time I worked on Circle was between 1994 and 1998

Well there is no need for me to have it in races.c if i can replace what i found in db.c

cant seem to find where max height and weight are defined, someone pls write.