Question case in spell

In magic.c

First started making case 1-3 that is just damage NP there. Then I wanted case 4: to be a spell, but that is causing me a lot of problems. Any ideas ??

int mag_damage(int level, struct char_data *ch, struct char_data *victim,
                    int spellnum, int savetype, struct affected_type af)  <<--Tried to add structs affected_type af here. If I don't add something about af then compiling says im using it without declaring.

  case SPELL_RAINBOW:
    if (IS_MAGIC_USER(ch))

      switch (rand_number(1, 4)) {
  case 1:dam=10;
  case 2:dam=20;
  case 3:dam=30;
  case 4:
    af[0].location = APPLY_STR;
    af[0].duration = GET_LEVEL(ch);
    af[0].modifier = -2;
    SET_BIT_AR(af[0].bitvector, AFF_POISON);

But then I get this error when compiling:

gcc -g -O2 -Wall    -c -o magic.o magic.c
magic.c:199: error: conflicting types for ‘mag_damage’
spells.h:405: error: previous declaration of ‘mag_damage’ was here
magic.c: In function ‘mag_damage’:
magic.c:313: error: subscripted value is neither array nor pointer
magic.c:314: error: subscripted value is neither array nor pointer
magic.c:315: error: subscripted value is neither array nor pointer
magic.c:316: error: subscripted value is neither array nor pointer
magic.c: In function ‘mag_areas’:
magic.c:1241: error: too few arguments to function ‘mag_damage’
make[1]: *** [magic.o] Error 1

When making a switch statement, you need to have breaks after each case. And you're not actually setting the dam variable in case 4:
The actual call that is failing to compile seems to be a call to damage() a little later in the function.

Yea I do have break; after each, was trying to simplify it

The 4 lines the compiler is complaining about is the 4 lines in case 4 that I showed that uses “af”

Is there any way that I can use call_magic within a spell to cast another spell ?

i tried this and it compiles just fine. But casting the spell gives me the right message for case 4 but no spell is cast.


  case SPELL_TESTSPELL:
    if (IS_MAGIC_USER(ch))
    send_to_char(ch, "\r\n");
    act("$n", FALSE, ch, NULL, NULL, TO_ROOM);
      switch (rand_number(1, 4)) {
      case 1:dam=10;
      act("$N", FALSE, ch, NULL, victim, TO_NOTVICT);
      act("", TRUE, ch, NULL, victim, TO_VICT);
      act("$N", FALSE, ch, NULL, victim, TO_CHAR);
      break;
      case 2:dam=20;
      act("$N", FALSE, ch, NULL, victim, TO_NOTVICT);
      act("", TRUE, ch, NULL, victim, TO_VICT);
      act("$N", FALSE, ch, NULL, victim, TO_CHAR);
      break;
      case 3:dam=30;
      act("$N", FALSE, ch, NULL, victim, TO_NOTVICT);
      act("", TRUE, ch, NULL, victim, TO_VICT);
      act("$N", FALSE, ch, NULL, victim, TO_CHAR);
      break;
      case 4:dam=0;
      act("$N", FALSE, ch, NULL, victim, TO_NOTVICT);
      act("", TRUE, ch, NULL, victim, TO_VICT);
      act("$N", FALSE, ch, NULL, victim, TO_CHAR);
      call_magic(victim, FIGHTING(ch), 0, SPELL_POISON, GET_LEVEL(ch), CAST_SPELL);  I tried switching                                                                                                             around victim and ch, didn't work either.
      break;
      default:
      dam=100;
      break;
}
break;

Any ideas ?

call_magic(ch, victim, NULL, SPELL_POISON, GET_LEVEL(ch), CAST_SPELL);

should work.

Also, add curly parenthesis to the if-check. Currently, the check only decides if a newline should be sent.