Question Improving a weapon proficiency

Just the name: When you create definitions like: '#define SKILL_WEAPON_SWORDS 160' we can use SKILL_WEAPONS_SWORDS instead of remembering that '160' is the number for the swords skill.
We can quickly search for all the places where we have used the skill etc.

Other good examples are #define MAX_SKILLS 200
If you were adding lots of skills one night because you drank too much coffee and just couldn't stop, you can update it to be #define MAX_SKILL 287. Then all the other (19) places in code that uses MAX_SKILLS automatically know it changed from 200 to 287 without having to manually update them. Woo!

Here's my compiler errors:

Add the top of fight.c add
void improve_skill (struct char_data *ch, int skill);

Thank you! I don't know how you guys are so smart, but thank you.

Difference between static void and void. When to use one instead of the other.

static means "visible in this compilation unit". In tbamud code this is the same as "visible in this file".

Typically you'd use static functions for "internal" functionality. For instance, in the lists.c code, only the functions without static can be called from other places. This is a crude but functional way of limiting access to functions you don't want other parts of the code to call.