This goes all the way back to Circle 3.1, where is where I found it. A quick check confirmed it was never changed.
I suggest the following minor edit.
Code:
/* Older, stock tbaMUD bit settings. */
- /** 1 if bit is set in flag, 0 if it is not set. */
+ /** 1 if bit is set in var, 0 if it is not set. */
- #define IS_SET(flag,bit) ((flag) & (bit))
+ #define IS_SET(var,bit) ((var) & (bit))
/** Set a specific bit in var to 1. */
#define SET_BIT(var,bit) ((var) |= (bit))
/** Set a specific bit bit in var to 0. */
#define REMOVE_BIT(var,bit) ((var) &= ~(bit))
/** If bit in var is off, turn it on; if it is on, turn it off. */
#define TOGGLE_BIT(var,bit) ((var) ^= (bit))
My claim is that it should be changed both for the sake of consistency as well as the fact that the word
flag (in my opinion) ought to be reserved for either boolean flags, or
left bit-shifts of 1 (that is, an integer with exactly one non-zero bit).
But we can live with this
