Question Not a crash - but another entry in file error from 3 days ago

JTP
Topic Author
Offline
Platinum Member

07 Apr 2018 17:23 #7893 by JTP

Not a crash - but another entry in file error from 3 days ago was created by JTP

What might have happened here since i see this in file error:

Apr 4 22:06:04 :: SYSERR: no valid target to act()!

?
Game didnt crash, but maybe a good idea to find out.

Please Log in or Create an account to join the conversation.

thomas
Offline
Administrator

08 Apr 2018 07:52 #7897 by thomas

Replied by thomas on topic Not a crash - but another entry in file error from 3 days ago

github.com/tbamud/tbamud/blob/0bb51e2bc2...36b/src/comm.c#L2676 :

Code:

 /* ASSUMPTION: at this point we know type must be TO_NOTVICT or TO_ROOM */

  if (ch && IN_ROOM(ch) != NOWHERE)
    to = world[IN_ROOM(ch)].people;
  else if (obj && IN_ROOM(obj) != NOWHERE)
    to = world[IN_ROOM(obj)].people;
  else {
    log("SYSERR: no valid target to act()!");
    return NULL;
  }

So, you are calling act(.., TO_ROOM) with a character in NOWHERE.

act() then warns about it and ignores the call.

Please Log in or Create an account to join the conversation.

JTP
Topic Author
Offline
Platinum Member

08 Apr 2018 07:57 - 08 Apr 2018 08:00 #7898 by JTP

Replied by JTP on topic Not a crash - but another entry in file error from 3 days ago

A so just a heads up. I'm beginning to hate these NOWHERE people haha

Last edit: 08 Apr 2018 08:00 by JTP.

Please Log in or Create an account to join the conversation.

lacrc
Offline
Senior Member

09 Apr 2018 12:10 #7901 by lacrc

Replied by lacrc on topic Not a crash - but another entry in file error from 3 days ago

Not sure if that would help but, we had an issue with one of those act() TO_ROOM calls and we just couldn't track it properly, so we added the act() message to the warning output.
It was kinda of messy in the logs but it worked. Something like:

Code:

log("SYSERR: no valid target to act()! - Text: %s", str);

Please Log in or Create an account to join the conversation.

JTP
Topic Author
Offline
Platinum Member

09 Apr 2018 12:20 #7902 by JTP

Replied by JTP on topic Not a crash - but another entry in file error from 3 days ago

I'm almost sure that mine was again a person that logged out before message was received.

But Nice idea with string

Please Log in or Create an account to join the conversation.

Time to create page: 0.191 seconds