Welcome to the Builder Academy

Question GUI for TBAmud

More
21 May 2017 02:28 #6758 by WhiskyTest
Replied by WhiskyTest on topic GUI for TBAmud
Just realised the following changes are also missing from 3.68, added here so the info is all in one place
(the change to write() is also required to stop the newlines, not sure about the reportbug() and infomessage() ones though)
Code:
in Protocol.C, line 39 static void Write( descriptor_t *apDescriptor, const char *apData ) { if ( apDescriptor != NULL && apDescriptor->has_prompt ) { if ( apDescriptor->pProtocol->WriteOOB > 0 || *(apDescriptor->output) == '\0' ) { apDescriptor->pProtocol->WriteOOB = 2; } } write_to_output( apDescriptor, apData ); } static void ReportBug( const char *apText ) { log( apText ); } static void InfoMessage( descriptor_t *apDescriptor, const char *apData ) { Write( apDescriptor, "\t[F210][\toINFO\t[F210]]\tn " ); Write( apDescriptor, apData ); apDescriptor->pProtocol->WriteOOB = 0; }

Please Log in or Create an account to join the conversation.

More
25 Nov 2017 23:54 #7159 by WhiskyTest
Replied by WhiskyTest on topic GUI for TBAmud
Just poking around with MSDP values and noticed that tbaMUD 3.68 is still sending a blank line along with MSDP data.
It's a quick fix, patch file attached.

Attachment msdp_bugfix_2017-11-25.zip not found

Attachments:

Please Log in or Create an account to join the conversation.

More
26 Nov 2017 00:17 #7160 by JTP
Replied by JTP on topic GUI for TBAmud
Any chance to post a txt file, i cant open zip

Please Log in or Create an account to join the conversation.

More
26 Nov 2017 01:18 #7162 by WhiskyTest
Replied by WhiskyTest on topic GUI for TBAmud
Here it is, in patch file format:
Ps: why can't you open zip files? Is tar/gz better?
Code:
diff -BbuprN -x '*.o' tbamud-3.68original/src/comm.c tbamud-3.68/src/comm.c --- tbamud-3.68original/src/comm.c 2017-11-26 11:09:03.056819800 +1300 +++ tbamud-3.68/src/comm.c 2017-11-26 12:44:44.712641300 +1300 @@ -1572,6 +1572,7 @@ static int process_output(struct descrip /* add the extra CRLF if the person isn't in compact mode */ if (STATE(t) == CON_PLAYING && t->character && !IS_NPC(t->character) && !PRF_FLAGGED(t->character, PRF_COMPACT)) + if ( !t->pProtocol->WriteOOB ) strcat(osb, "\r\n"); /* strcpy: OK (osb:MAX_SOCK_BUF-2 reserves space) */ if (!t->pProtocol->WriteOOB) /* add a prompt */ @@ -1579,7 +1580,7 @@ static int process_output(struct descrip /* now, send the output. If this is an 'interruption', use the prepended * CRLF, otherwise send the straight output sans CRLF. */ - if (t->has_prompt) { + if (t->has_prompt && !t->pProtocol->WriteOOB) { t->has_prompt = FALSE; result = write_to_descriptor(t->descriptor, i); if (result >= 2) diff -BbuprN -x '*.o' tbamud-3.68original/src/protocol.c tbamud-3.68/src/protocol.c --- tbamud-3.68original/src/protocol.c 2017-11-26 11:09:04.634011300 +1300 +++ tbamud-3.68/src/protocol.c 2017-11-26 12:46:08.232726300 +1300 @@ -40,7 +40,7 @@ static void Write( descriptor_t *apDescr { if ( apDescriptor != NULL) { - if ( apDescriptor->pProtocol->WriteOOB > 0) + if ( apDescriptor->pProtocol->WriteOOB > 0 || *(apDescriptor->output) == '\0' ) { apDescriptor->pProtocol->WriteOOB = 2; }

Please Log in or Create an account to join the conversation.

More
26 Nov 2017 01:48 #7163 by Sascha
Replied by Sascha on topic GUI for TBAmud
Good stuff. I plan to poke around with this, and I'll hit you up in 10 days or so with questions, I'm sure. :)
Will you stand against the coming Storm? After the Breaking: STORMRIDERS MUD - atbmud.dune.net port 4000
The following user(s) said Thank You: WhiskyTest

Please Log in or Create an account to join the conversation.

More
26 Nov 2017 23:37 #7165 by Ornir
Replied by Ornir on topic GUI for TBAmud
This is fantastic, WhiskyTest! This big has been irritating me for a really long time!

I am working on a GUI for LuminariMUD right now and have been using MSDP extensively. I would love to compare notes and bounce stuff off of you if you are up for it!
I want to extend the protocol to allow the client to request specific data from the server, such as item identification data.

I am Ornir in the game, if you drop by.

luminarimud.com 4100
Luminari - a Pathfinder/D&D inspired adventure!
www.luminarimud.com
luminarimud.com 4100

Please Log in or Create an account to join the conversation.

Time to create page: 0.201 seconds

tbaMUD © 2024