Will this snippet work as is with tba ?

  • JTP
  • JTP's Avatar Topic Author
  • Offline
  • Platinum Boarder
  • Platinum Boarder
More
4 months 1 week ago #7330 by JTP
JTP replied the topic: Will this snippet work as is with tba ?
Anyone who knows what is needed to use caps in the clan name ?

Please Log in or Create an account to join the conversation.

More
4 months 1 week ago #7331 by WhiskyTest
WhiskyTest replied the topic: Will this snippet work as is with tba ?
I'll have a crack at it tonight

Please Log in or Create an account to join the conversation.

More
4 months 1 week ago #7332 by Parnassus
Parnassus replied the topic: Will this snippet work as is with tba ?
The code apparently needs a toupper() in there somewhere. I don't know how it works but Vatikan mentioned it in this thread.

Please Log in or Create an account to join the conversation.

More
4 months 1 week ago #7333 by thomas
thomas replied the topic: Will this snippet work as is with tba ?
Ok. Try this on for size. ;)
Attachments:

Please Log in or Create an account to join the conversation.

  • JTP
  • JTP's Avatar Topic Author
  • Offline
  • Platinum Boarder
  • Platinum Boarder
More
4 months 1 week ago #7334 by JTP
JTP replied the topic: Will this snippet work as is with tba ?
Can't open zip :(

Please Log in or Create an account to join the conversation.

More
4 months 1 week ago #7335 by thomas
thomas replied the topic: Will this snippet work as is with tba ?
Tried a repackage on windows. Same contents, but now the zipfile behaves correctly also under non-linux.
Attachments:

Please Log in or Create an account to join the conversation.

  • JTP
  • JTP's Avatar Topic Author
  • Offline
  • Platinum Boarder
  • Platinum Boarder
More
4 months 1 week ago #7336 by JTP
JTP replied the topic: Will this snippet work as is with tba ?
Well i work on iPad, never been able to open zip

Please Log in or Create an account to join the conversation.

  • JTP
  • JTP's Avatar Topic Author
  • Offline
  • Platinum Boarder
  • Platinum Boarder
More
4 months 6 days ago #7341 by JTP
JTP replied the topic: Will this snippet work as is with tba ?
ok got someone to open it and send.

But what did you change in it ?

What should i look for ?

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7343 by thomas
thomas replied the topic: Will this snippet work as is with tba ?
First things first: Here's how to open zip files on your ipad .

Ok, so what happened in the patch file?
I rewrote clans so they do the things you asked for (minus the ability to have a mob clan leader - I have no idea how you'd want that to even work).
I tried to make the clan.c file as self-contained as possible, and in practice it handles everything relevant to clans; the clan list, the loading and saving, every command a player or immort can make, etc.
In clan.h we export the few functions needed in the rest of the system. In db.c we trigger the loading and freeing of clan data, and in interpreter.c we add the "clan" command to the main command list. In comm.c we make sure online clan members have the correct clan set.
I would suggest removing any changes made by the previous patch, before adding this. They are not compatible - the macros exported by the previous patch do not exist anymore.

The original clan patch had no concept of a clan (no really, hear me out). It simply delegated the right to set an extra title. Due to this, it was extremely difficult to make changes to the clan; after all, if I changed the name of the clan, every current member would be thrown out - their save file would not match. But they'd still have the old name pop up in the who list. Now, though, no one could dismiss them from their clan, because there was no clan by that name that had a leader. What if a clan leader left the clan?

With this clan system, the clan leader currently can set clan name and individual rank names and the code is ready to add more functionality to clans, because there's already a load/save mechanism in place. There's a relationship from clan to members, meaning that any changes in the clan are immediately visible to all members. If a clan leader leaves the clan, the next highest ranked member steps up as leader, or it is disbanded.
Most, if not all of this is apparent from the help entry lined out in the README. Please help me making it better - what is missing there?
The following user(s) said Thank You: WhiskyTest, Sascha

Please Log in or Create an account to join the conversation.

  • JTP
  • JTP's Avatar Topic Author
  • Offline
  • Platinum Boarder
  • Platinum Boarder
More
4 months 5 days ago #7346 by JTP
JTP replied the topic: Will this snippet work as is with tba ?
I think it was sascha that needed the hole thing, i already have the old version in. I just need the code to allow Big letters, but getting cross eyes trying to find where that was fixed.

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7347 by thomas
thomas replied the topic: Will this snippet work as is with tba ?
Actually I just made it possible to change the name. So the owner can add small or capital letters after their own wishes.

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7351 by Fizban
Fizban replied the topic: Will this snippet work as is with tba ?
Is it you or Rumble that has access to drive.google.com/drive/u/0/folders/0B40XbRH2Qbx5NmVmT3BWaFlIeUk

Uploading the clan patch to there (unless just adding it to the release is preferred) is probably better than just uploading it in this thread, since far more people will likely stumble upon it that way.

Please Log in or Create an account to join the conversation.

  • JTP
  • JTP's Avatar Topic Author
  • Offline
  • Platinum Boarder
  • Platinum Boarder
More
4 months 5 days ago #7352 by JTP
JTP replied the topic: Will this snippet work as is with tba ?
Was it just clan.c you changed alot in ?

Im wondering if i can just paste that into my clan.c

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7354 by thomas
thomas replied the topic: Will this snippet work as is with tba ?

JTP wrote: Was it just clan.c you changed alot in ?

Im wondering if i can just paste that into my clan.c

thomas wrote: I would suggest removing any changes made by the previous patch, before adding this. They are not compatible - the macros exported by the previous patch do not exist anymore.

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7355 by thomas
thomas replied the topic: Will this snippet work as is with tba ?

Fizban wrote: Is it you or Rumble that has access to drive.google.com/drive/u/0/folders/0B40XbRH2Qbx5NmVmT3BWaFlIeUk

Uploading the clan patch to there (unless just adding it to the release is preferred) is probably better than just uploading it in this thread, since far more people will likely stumble upon it that way.


Just checked - I have no access.

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7356 by Rumble
Rumble replied the topic: Will this snippet work as is with tba ?
uploaded

Rumble
The Builder Academy
tbamud.com 9091

Please Log in or Create an account to join the conversation.

  • JTP
  • JTP's Avatar Topic Author
  • Offline
  • Platinum Boarder
  • Platinum Boarder
More
4 months 5 days ago #7360 by JTP
JTP replied the topic: Will this snippet work as is with tba ?
What was wrong with the old version, some serious changes has been made it seems

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7363 by Sascha
Sascha replied the topic: Will this snippet work as is with tba ?
First, let me say I am so astonished that you tackled my request, and so quickly! I am grateful that you made such a comprehensive list of changes so that I, and anyone else who uses this patch, know what to do and how to do it. Thank you, thank you, thank you.

I am leaving on a business trip first thing in the morning and I don't think I'll have time to roll back the prior snippet changes and imp this one, but as soon as I get back I'm going to tackle it. I don't want you to think "Man, she asked for this and ghosted..." :) (I feel like that kid who got the perfect present on Christmas Day, only to be told I can't play with it now because we have to go to Grandma's. LOL!)

Dovie'andi se tovya sagain. After the Breaking MUD, now in beta testing...

Please Log in or Create an account to join the conversation.

More
4 months 5 days ago #7366 by WhiskyTest
WhiskyTest replied the topic: Will this snippet work as is with tba ?
Cool Thomas, much more functionality to play with!

I did end up getting a crash at login in add_existing_clan()
Now, I did create and delete a lot of random clans - so may have just messed up my files.
But adding the below line settled it down.
void add_existing_clan(struct char_data *ch)
{
  struct clan_data *clan = clan_list;
  while (clan)
  {
    if(find_clan_member(clan, GET_NAME(ch)))
      break;

    clan = clan->next;
  }
-   GET_CLAN(ch) = clan;
+  GET_CLAN(ch) = clan ? clan : 0;
}
The following user(s) said Thank You: Sascha

Please Log in or Create an account to join the conversation.

More
3 months 4 weeks ago #7419 by Sascha
Sascha replied the topic: Will this snippet work as is with tba ?
I was able to install this patch this morning. Works like a dream! No warnings when compiling, either. This is a super addition. Thank you again for tackling this.

Dovie'andi se tovya sagain. After the Breaking MUD, now in beta testing...

Please Log in or Create an account to join the conversation.

Time to create page: 1.784 seconds