Waterskin problem

I remember this issue as well. Every water container was required to have the drink type as an alias/keyword and there was a SYSERR when it didn't. It was annoying, I'm glad we removed it. I assume the original purpose was so when you drank all of your <liquid> you could no longer drink from it but still drink <container alias> to get the empty message.

The problem is that you have an object with the alias "water waterskin" and the algorithm, when you empty the container, will try to remove the "water" alias from the list.
So it removes "water", and checks the resulting list of names ("waterskin") again. And it finds the word "water" inthere.
In an older version of the codebase there is a bug here, that results in not checking the length of the words to remove. So, if the word contains "water", all of it is removed.

Now, if you do the same with a cup, which has the alias list "cup water", once it has removed the "water" keyword, you still have "cup".
Once you fill it again, it will get the fluid name appended to the alias list again. So if you have a cup of water ("cup water") and empty it ("cup") and then fill it with firebreather, you'll get a "cup firebreather".

This is why it works with cups, but not your waterskin.

The bug is fixed in the current version, as far as I know.

Good question. It's all in this commit: github.com/tbamud/tbamud/commit/dceb563a...381823ff201a404ab6f5