Badly chosen parameter name for old macro in utils.h (cosmetic issue)

Start
Prev
1
Next
End

doggo
Topic Author
Offline
New Member

3 years 7 months ago #8577 by doggo

Badly chosen parameter name for old macro in utils.h (cosmetic issue) was created by doggo

This goes all the way back to Circle 3.1, where is where I found it. A quick check confirmed it was never changed.

I suggest the following minor edit.

  /* Older, stock tbaMUD bit settings. */
- /** 1 if bit is set in flag, 0 if it is not set. */
+ /** 1 if bit is set in var, 0 if it is not set. */
- #define IS_SET(flag,bit)  ((flag) & (bit))
+ #define IS_SET(var,bit)  ((var) & (bit))
  /** Set a specific bit in var to 1. */
  #define SET_BIT(var,bit)  ((var) |= (bit))
  /** Set a specific bit bit in var to 0. */
  #define REMOVE_BIT(var,bit)  ((var) &= ~(bit))
  /** If bit in var is off, turn it on; if it is on, turn it off. */
  #define TOGGLE_BIT(var,bit) ((var) ^= (bit))

My claim is that it should be changed both for the sake of consistency as well as the fact that the word flag (in my opinion) ought to be reserved for either boolean flags, or left bit-shifts of 1 (that is, an integer with exactly one non-zero bit).

Please Log in or Create an account to join the conversation.

Castillo
Offline
Junior Member

3 years 7 months ago #8578 by Castillo

Replied by Castillo on topic Badly chosen parameter name for old macro in utils.h (cosmetic issue)

I'm now reporting at github.com/tbamud/tbamud/issues

Yes, bug reports on github is nice :)

I still have issues reported there. It has been about 2 weeks there is no respond from the developers.

There is a couple of issues in standby like MAX_NAME_LENGTH and this:

www.tbamud.com/forum/4-development/4534-...-install-tbamud-2020

This is ok. Even better would be a pull request on github :) But we can live with this :)

I'm just reporting, but maybe if you send pull request. You'll have better luck! Atlease you offer patches.

They maybe busy.

Bob

Please Log in or Create an account to join the conversation.

doggo
Topic Author
Offline
New Member

3 years 7 months ago #8579 by doggo

Replied by doggo on topic Badly chosen parameter name for old macro in utils.h (cosmetic issue)

Unfortunately, I'm complete incompetent when it comes to using any .git commands.

Learning it is on my todo-list, but for now I use a homemade version control locally.

When I encounter things, I'll post them here. People can do with them what they want. :)

The following user(s) said Thank You: thomas

Please Log in or Create an account to join the conversation.

thomas
Offline
Administrator

3 years 7 months ago #8581 by thomas

Replied by thomas on topic Badly chosen parameter name for old macro in utils.h (cosmetic issue)

Strangely enough, I haven't received a message about your issues. I'll see what's up with my notifications...

Please Log in or Create an account to join the conversation.

thomas
Offline
Administrator

3 years 7 months ago #8582 by thomas

Replied by thomas on topic Badly chosen parameter name for old macro in utils.h (cosmetic issue)

Also, it's been a couple of busy weeks.

Please Log in or Create an account to join the conversation.

doggo
Topic Author
Offline
New Member

3 years 7 months ago #8583 by doggo

Replied by doggo on topic Badly chosen parameter name for old macro in utils.h (cosmetic issue)

Understood! I all but disappear from the MUD world entirely when my life gets busy. :)

Please Log in or Create an account to join the conversation.

Start
Prev
1
Next
End

Time to create page: 0.113 seconds